Announcement

Collapse
No announcement yet.

[Beta 7] Language/Style issues and typos

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

  • [Beta 7] Language/Style issues and typos

    Hello,

    This is our Beta 7 edition. Each time, the thread is shorter and shorter, so this is good news.

    Previous thread was : [size=1][Beta 6] Language/Style issues and typos[/size]

    Now, let's begin.

    template buddylistbit
    <td><img src="$stylevar[imgdir_statusicon]/user_$buddy[statusicon].gif" alt="" title="$buddy[username] is buddy[statusicon]" border="0" /></td>
    It should be $buddy[statusicon] instead of buddy[statusicon]. (reported by Sophocle)

    fixed
    Last edited by Scott MacVicar; Thu 25 Sep '03, 4:29pm.
    Lumina, aventurière des mondes fantastiques et petite rédactrice au grand cœur
    Cœur Lumière - vBulletin-fr
    Join the vBulletin French community social group!

  • #2
    vbphrases from “Style Tools”, comparison between input_fields and textarea_columns.

    Both phrases refer to titles from the same page :
    /admincp/css.php?do=edit&dowhat=all&dostyleid=1

    But there is a small inconsistency with the handle of special chars, like international ones, or like < and >.

    1) If I translate using < and > (for example), then:
    => input_fields displays well.
    => textarea_columns display very bad, because it is interpreted as real HTML.

    2) If I translate using &lt; and &gt; (for example), then:
    => input_fields displays bad, because HTML entities aren't recognized.
    => textarea_columns display well.

    Ok, this was an example with < and >. But there can be other issues with other special chars, especially the international ones, like it was reported here:
    http://www.vbulletin.com/forum/showpost.php?p=530307


    Suggested fix
    (all steps need to be done)

    1) function print_css_row() in file \includes\adminfunctions_template.php
    Remove or comment line 2074 :
    $title = htmlspecialchars_uni($title);

    2) file \admincp\css.php
    Change line 455 :
    print_css_row('<td>, <th>, <p>, <li>', 'td, th, p, li', 0);
    With :
    print_css_row('&lt;td&gt;, &lt;th&gt;, &lt;p&gt;, &lt;li&gt;', 'td, th, p, li', 0);

    3) vbphrases menus and input_fields
    Change < and > with &lt; and &gt;

    Thank you very much.
    Lumina, aventurière des mondes fantastiques et petite rédactrice au grand cœur
    Cœur Lumière - vBulletin-fr
    Join the vBulletin French community social group!

    Comment


    • #3
      Hello,

      I'm Lumina's french co-translator and I've found another little trouble in FORUMDISPLAY template. The filename has changed but not the alternative text

      <td><img src="$stylevar[imgdir_statusicon]/thread_new.gif" alt="folder_new.gif" title="New Posts" border="0" /></td>
      <td><img src="$stylevar[imgdir_statusicon]/thread_hot_new.gif" alt="folder_hot_new.gif" title="Hot Thread With New Posts" border="0" /></td>
      <td><img src="$stylevar[imgdir_statusicon]/thread.gif" alt="folder.gif" title="No New Posts" border="0" /></td>
      <td><img src="$stylevar[imgdir_statusicon]/thread_hot.gif" alt="folder_hot.gif" title="Hot Thread With No New Posts" border="0" /></td>
      <td><img src="$stylevar[imgdir_statusicon]/thread_lock.gif" alt="folder_lock.gif" title="Closed Thread" border="0" /></td>
      <td><img src="$stylevar[imgdir_statusicon]/thread_dot.gif" alt="folder_dot.gif" title="Thread Contains a Message Written By You" border="0" /></td>
      fixed
      Last edited by Scott MacVicar; Mon 29 Sep '03, 2:39pm.
      forum.vbulletin-fr.com admin

      Comment


      • #4
        template help_bbcodes

        When describing the [left] bbcode :
        Code:
         <td class="alt1" align="[color=red]$stylevar[/color][color=red][[/color]left[color=red]][/color]">text to the left</td>
        It should be replaced with :
        Code:
         <td class="alt1" align="left">text to the left</td>
        When describing the [right] bbcode :
        Code:
         <td class="alt1" align="[color=red]$stylevar[/color][color=red][[/color]right[color=red]][/color]">text to the right</td>
        It should be replaced with :
        Code:
         <td class="alt1" align="right">text to the right</td>
        fixed
        Last edited by Scott MacVicar; Mon 29 Sep '03, 2:34pm.
        Lumina, aventurière des mondes fantastiques et petite rédactrice au grand cœur
        Cœur Lumière - vBulletin-fr
        Join the vBulletin French community social group!

        Comment


        • #5
          template MEMBERINFO
          Some background colors are not correctly alternated.
          Code:
          <if condition="$vboptions['usereferrer']==1 AND exec_switch_bg()">
          Should be:
          Code:
          <if condition="[color=red][b][color=green]exec_switch_bg() AND[/color] [/b][/color]$vboptions['usereferrer']==1 AND exec_switch_bg()">
          Code:
           <td class="alt[color=red][b]1[/b][/color]"><b>MSN ID</b></td>
          <td class="alt[color=red][b]1[/b][/color]"><if condition="$userinfo[msn]">
          Should be:
          Code:
           <td class="alt[color=green][b]2[/b][/color]"><b>MSN ID</b></td>
          <td class="alt[color=green][b]2[/b][/color]"><if condition="$userinfo[msn]">
          FIXED RC1
          Last edited by Freddie Bingham; Mon 20 Oct '03, 1:38pm.
          Lumina, aventurière des mondes fantastiques et petite rédactrice au grand cœur
          Cœur Lumière - vBulletin-fr
          Join the vBulletin French community social group!

          Comment


          • #6
            just to get all errors together in one thread
            reported here

            FIXED
            Attached Files
            Last edited by Scott MacVicar; Mon 29 Sep '03, 2:31pm.
            That's the end of that!

            Comment


            • #7
              Another little mistake with alt text :
              newattachmentbit template
              <td><img src="$stylevar[imgdir_attach]/$attach[extension].gif" alt="attach/$attach[extension].gif"
              Should be :
              <td><img src="$stylevar[imgdir_attach]/$attach[extension].gif" alt="$attach[extension].gif"
              fixed
              Last edited by Scott MacVicar; Mon 29 Sep '03, 2:40pm.
              forum.vbulletin-fr.com admin

              Comment


              • #8
                Same problem with alt text in newreply_attachmentbit template
                PHP Code:
                <img src="$stylevar[imgdir_attach]/$attach[extension].gif" alt="attach/$attach[extension].gif" 
                Should be :
                PHP Code:
                <img src="$stylevar[imgdir_attach]/$attach[extension].gif" alt="$attach[extension].gif" 
                FIXED
                Last edited by Freddie Bingham; Mon 20 Oct '03, 3:02pm.
                forum.vbulletin-fr.com admin

                Comment


                • #9
                  Same problem with alt text in pollresulttemplate
                  <img src="$stylevar[imgdir_poll]/bar$option[graphicnumber]-l.gif" alt="polls/bar$option[graphicnumber]-l.gif" title="" width="3" height="10"
                  ><img src="$stylevar[imgdir_poll]/bar$option[graphicnumber].gif" alt="polls/bar$option[graphicnumber].gif" title="" width="$option[barnumber]" height="10"
                  ><img src="$stylevar[imgdir_poll]/bar$option[graphicnumber]-r.gif" alt="polls/bar$option[graphicnumber]-r.gif"
                  Should be :
                  <img src="$stylevar[imgdir_poll]/bar$option[graphicnumber]-l.gif" alt="bar$option[graphicnumber]-l.gif" title="" width="3" height="10"
                  ><img src="$stylevar[imgdir_poll]/bar$option[graphicnumber].gif" alt="bar$option[graphicnumber].gif" title="" width="$option[barnumber]" height="10"
                  ><img src="$stylevar[imgdir_poll]/bar$option[graphicnumber]-r.gif" alt="bar$option[graphicnumber]-r.gif"
                  FIXED
                  Last edited by Freddie Bingham; Mon 20 Oct '03, 3:03pm.
                  forum.vbulletin-fr.com admin

                  Comment


                  • #10
                    template MODIFY
                    Some background colors are not correctly alternated.
                    <if condition="$showlanguagecell">
                    [..]

                    <if condition="$showstylecell">
                    <tr>
                    <td class="alt1"><b>Style Set</b><br />
                    <span class="smallfont">You may pick a style set to browse with that may or may not override the default settings.</span></td>
                    <td class="alt1"><span class="smallfont">
                    <select name="newstyleset">
                    $stylesetlist
                    </select>
                    </span></td>
                    </tr>
                    </if>
                    <tr>
                    <td class="alt2"><b>Avatar</b><br />
                    <span class="smallfont"><a href="misc.php?$session[sessionurl]do=showavatars" target="_blank">More info...</a></span></td>
                    <td class="alt2"><img src="$bbuserinfo[avatarurl]" border="0" alt="Your current avatar" align="middle" /> <input type="submit" class="button" name="modifyavatar" value="Change Avatar" /></td>
                    </tr>
                    Should be:
                    <if condition="exec_switch_bg() AND $showlanguagecell AND exec_switch_bg()">
                    [..]
                    <if condition="$showstylecell AND exec_switch_bg()">
                    <tr>
                    <td class="$bgclass"><b>Style Set</b><br />
                    <span class="smallfont">You may pick a style set to browse with that may or may not override the default settings.</span></td>
                    <td class="$bgclass"><span class="smallfont">
                    <select name="newstyleset">
                    $stylesetlist
                    </select>
                    </span></td>
                    </tr>
                    </if>

                    <if condition="exec_switch_bg()"></if>
                    <tr>
                    <td class="$bgclass"><b>Avatar</b><br />
                    <span class="smallfont"><a href="misc.php?$session[sessionurl]do=showavatars" target="_blank">More info...</a></span></td>
                    <td class="$bgclass"><img src="$bbuserinfo[avatarurl]" border="0" alt="Your current avatar" align="middle" /> <input type="submit" class="button" name="modifyavatar" value="Change Avatar" /></td>
                    </tr>
                    FIXED, though I did not use the suggested methods as those are quite kludgy.
                    Last edited by Freddie Bingham; Mon 20 Oct '03, 3:04pm.
                    Lumina, aventurière des mondes fantastiques et petite rédactrice au grand cœur
                    Cœur Lumière - vBulletin-fr
                    Join the vBulletin French community social group!

                    Comment


                    • #11
                      template help_bbcodes




                      Wrong closing tag
                      <td class="alt1"><font size="+2">this text is two sizes larger</size></td>




                      Should be
                      <td class="alt1"><font size="+2">this text is two sizes larger</font></td>




                      And
                      <td class="alt1" align="center">text to the center</font></td>


                      Should be
                      <td class="alt1" align="center">text to the center</td>


                      FIXED
                      Last edited by Freddie Bingham; Mon 20 Oct '03, 3:08pm.
                      Lumina, aventurière des mondes fantastiques et petite rédactrice au grand cœur
                      Cœur Lumière - vBulletin-fr
                      Join the vBulletin French community social group!

                      Comment


                      • #12
                        Again help_bbcodes

                        Would it be possible to have the examples output for [ quote ], [ code ], [ php ] and [ html ] always dependant of the following templates :
                        bbcode_code
                        bbcode_html
                        bbcode_php
                        bbcode_quote

                        Thanks.

                        WHY do these built in bbcodes need their own template? Their usage is already defined in help_bbcodes.
                        Last edited by Freddie Bingham; Mon 20 Oct '03, 3:10pm.
                        Lumina, aventurière des mondes fantastiques et petite rédactrice au grand cœur
                        Cœur Lumière - vBulletin-fr
                        Join the vBulletin French community social group!

                        Comment


                        • #13
                          not sure where this is located in phrases
                          forums/admincp/user.php?do=prune

                          but it should be Posts "are" lesser than instead of is

                          Comment


                          • #14
                            in Beta 7 version.

                            i was trying to change the text at the bottom:

                            All times are GMT +1 hour. The time now is ...

                            But i wasnt able to change that word "hour" or "hours". Turn out those two are still hardcoded.

                            file /includes/function.php

                            functions.php - line 4269: $timediff = " $bbuserinfo[tzoffset] hour";
                            functions.php - line 4273: $timediff = " $bbuserinfo[tzoffset] hours";


                            should they be like this?


                            $timediff = " $bbuserinfo[tzoffset] $vbphrase[hour]";
                            $timediff = " $bbuserinfo[tzoffset] $vbphrase[hours]";


                            <edited>
                            well, the above $vbphrase[hour] doesnt work. I added value of $vbphrase to global on function fetch_time_data() but the value for these $vbphrase[] are not displayed.

                            I guess vBdev will know how to fix it.

                            ....
                            well I would just take them out and put into template
                            Last edited by mtha; Wed 26 Nov '03, 2:04am.

                            Comment


                            • #15
                              Also this one 'Tomorrow' is hardcoded.

                              file /includes/function.php - line 4331


                              if ($returndate == TODAYDATE)
                              {
                              $returndate = $vbphrase['today'];
                              }
                              else if ($returndate == YESTDATE)
                              {
                              $returndate = $vbphrase['yesterday'];
                              }
                              else if ($returndate == TOMDATE)
                              {
                              $returndate = 'Tomorrow'; // Back to the Future!
                              }
                              Last edited by mtha; Wed 26 Nov '03, 2:05am.

                              Comment

                              widgetinstance 262 (Related Topics) skipped due to lack of content & hide_module_if_empty option.
                              Working...
                              X