My findings while upgrading from 5.0.5 to 5.1.0

[Guest]

I will try to post my findings in this topic regarding the update from 5.0.5 to 5.1.0.


Problem 1:

At the moment I'm running a test upgrade and the first run of the upgrade script gave me this error:

<b>Warning</b>:  array_merge(): Argument #1 is not an array in <b>C:\website\core\vb\datastore\filecache.php</b> on line <b>148</b><br />
<?xml version="1.0" encoding="windows-1252"?>
<upgrade>
         <message replace="0">Updating channel table</message>
         <status>Status: Processing 5.1.0 Alpha 1, Step 7 of 19</status>
         <longversion>5.1.0 Alpha 1</longversion>
         <version>510a1</version>
         <nextstep>7</nextstep>
</upgrade>

After that he aborts the upgrade. Strange enough, when I retry the upgrade he continues where he first gave this error. Then he hangs at the most final step XML processing step 17/17 and needs to be restarted also. And after that the upgrade seems to be succesful (step 17/17 only took 1 second).

I did the upgrade twice, to be sure the above problems re-occur and they did.

Problem 2:

The second thing is that after the upgrade my customized pages are gone. They are replaced by the default pages. I mean the pages I made with the Site Builder, some I gave a new template name (like the homepage). I still can see my made template, but when I select the template, the page is completely empty and I need to design it all over again.


Problem 3:

When I upload a photo in a thread via the 'Image button' in the Advanced Editor and I choose for Upload - Send to server. It appears in the post. I type some text and after that I push the post button.

After that I receive the error:

You are not authorized to create this post.

But when I refresh the page, my post seems to be inserted in the database. When I ry it again, It gives the same error. When I push the Post button again it tells me that I'm trying to post a duplicate message.

When I discover more findings, I'll update my topic.

[Zachery]

Problem 2 is a know bug, the page templates can't be re-used right now. But I've never seen custom pages disappear. So if you go to the custom page post upgrade, there is nothing on it?

Problem 3 do you have a bunch of custom permissions? Is this as an administrator or a default user?

[Mark.B]

GuiltyNL, we really appreciate this feedback. With regards to number 3, do you have comments disabled at all?

[Guest]

Problem 2 is a know bug, the page templates can't be re-used right now. But I've never seen custom pages disappear. So if you go to the custom page post upgrade, there is nothing on it?

Problem 3 do you have a bunch of custom permissions? Is this as an administrator or a default user?

Ok, no problem I'll recreate the template. For the page, I'm not sure when it is a custom page. Is it already custom when I rename a standard page? Or is it only custom when it has a new theurl/pagename? Or is it only custom when I add a new page that was built completely from scratch?

I have to check this on Monday.

No we don't have custom permissions. At least not for the admin user. The error occured whike testing with the default admin user. Sorry I forgot to tell this.

GuiltyNL, we really appreciate this feedback. With regards to number 3, do you have comments disabled at all?

Pre upgrade the comments are disabled. As I had only the choice to globally disable it in 5.0.5 we did so because our users don't yet understand the difference between a reply and a comment.

So after the update it stil has been disabled. But from what I've read the comment permissions has been moved to the user groups. So I will check this. Do you think it has something to do with the comment permissions? It doesn't make sense to me?

Edit: I've tested it and indeed it has something to do with the comments. You have to allow comments generally and you also need to grant a usergroup post comment right else uploading a picture and trying to post it gives this error.

We don't want all users to be able to use comments. But we do want all users to upload pictures. I think this combo won't work in 5.1.0 because of this bug?

[IggyP]

good info on issue 3, just noticed that myself nice you already sorted it

[Mark.B]

It could be....I'm not sure as yet with 5.1.0, but I've seen some sites where disabling the comments caused ordinary users to get "not authorised" errors when trying to make posts with attachments. Not every site though, which is weird.

I've edited my post, it has indeed to do with the comments.

[Mark.B]

Yes...just confirmed this myself...it's the same bug that used to affect the old global setting.

I'll log a bug tomorrow.

In the meantime, I "disabled" comments using css - display:none.

[Guest]

I tried to hide it but no succes. What css did you exactly use Mark? As the ID has a unique identifier and somehow I'm unable to hide the class.

Another simple trick did work, but it is not a nice way to do it:

In template conversation_footer change line 92 from:

            <vb:if condition="(!empty($controls['showCommentCtrl']) OR !empty($showAll)) AND $conversation['can_comment'] [B]>[/B] 0">

To:

            <vb:if condition="(!empty($controls['showCommentCtrl']) OR !empty($showAll)) AND $conversation['can_comment'] [B]=[/B] 0">

Does solve it, but it is a bit nasty

[IggyP]

good luck with that attachment box fix im still pushing toward albums use and hoping things get worked in better for those but would be nice for now...might have to try that

about the lag on step 17 tho, its the one part that takes some time if you have custom styles it takes time to merge the templates....if you click details you can see it cycle thru each style

[Guest]

Did some PHP 5.5 testing too, but it seems there are still some Deprecated issues in it:

[B]Deprecated[/B]: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in [B]string.php[/B] on line [B]753[/B]

[Mark.B]

I tried to hide it but no succes. What css did you exactly use Mark? As the ID has a unique identifier and somehow I'm unable to hide the class.

Another simple trick did work, but it is not a nice way to do it:

In template conversation_footer change line 92 from:

 <vb:if condition="(!empty($controls['showCommentCtrl']) OR !empty($showAll)) AND $conversation['can_comment'] [B]>[/B] 0">

To:

 <vb:if condition="(!empty($controls['showCommentCtrl']) OR !empty($showAll)) AND $conversation['can_comment'] [B]=[/B] 0">

Does solve it, but it is a bit nasty

Well that would work I guess, though if you're going to hack the template about you might as well just remove it totally.

I used css, add this to the template css_additional.css:

.js-post-control__comment {
  display: none !important;
}

[Guest]

Hmm I think I made a typo then, as I tried that one too. Will retry soon.

[Mark.B]

Did some PHP 5.5 testing too, but it seems there are still some Deprecated issues in it:

[B]Deprecated[/B]: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in [B]string.php[/B] on line [B]753[/B]

vB5 isn't certified for php 5.5 yet...couple of releases away this should happen.

[Guest]

I thought I've read somewhere (in a change log or something) improved PHP 5.5 compatibility, but maybe I'm wrong.

[Mark.B]

I thought I've read somewhere (in a change log or something) improved PHP 5.5 compatibility, but maybe I'm wrong.

There is one bug that is perhaps misleadingly titled "php 5.5 compatibility" but it only deals with one issue.
The rest of the issues will be sorted in a forthcoming release, possibly 5.1.2 but this is not confirmed at this time.

[Guest]

NP it was just a test out.of curiousity.