Announcement

Collapse
No announcement yet.

vb5.6.2 admincp templatemgr revert/customize/view buttons not working

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

  • [Bug / Issue] vb5.6.2 admincp templatemgr revert/customize/view buttons not working

    Upgrade vb5.6.1 to 5.6.2. AdminCP Template Mgr buttons Customize/Edit/Revert don't do anything. Debug console in firefox gives error 'button.form not defined'

    Since it DID work in 5.6.1 I did some digging in "./clientscript/vbulletin_templatemgr.js" and found that the buttonClick function appears to be broken, it looks like this for 5.6.2:

    Code:
    function buttonclick(a,b,c){eval("el = button.form.tl"+b);return!1}
    which won't work, 'cos button isn't in function header. When I replaced that function with the one in vb5.6.1 the buttons work in vb5.6.2 adminCP. But I don't want to go into production like that of course

    Is this the correct way to report bugs or should I create a ticket in the bugtracker somehow?

    Running vb5.6.2 on CentOs7, MySql 5.7, php 7.4.7, browsers used Firefox 77 and Chrome 83 on Win10 US. (local test server)

  • #2
    Appears to be a bug either with updating and consolidating JavaScript for both performance and security purposes or the new Javascript Compiler that is being used. I created a bug here: https://tracker.vbulletin.com/vbulle...sues/VBV-20419

    Replacing the function shouldn't hurt your production site. The AdminCP doesn't share Javascript with the Front-end. Plus you can close off your AdminCP with two-factor authentication.
    Translations provided by Google.

    Wayne Luke
    The Rabid Badger - a vBulletin Cloud demonstration site.
    vBulletin 5 API - Full / Mobile
    Vote for your favorite feature requests and the bugs you want to see fixed.

    Comment


    • #3
      This is due to the Javascript compiler we switched to in vBulletin 5.6.2. The previous compiler is not longer in production or supported. I've attached a recompiled file using the older compiler.

      Attached Files
      Translations provided by Google.

      Wayne Luke
      The Rabid Badger - a vBulletin Cloud demonstration site.
      vBulletin 5 API - Full / Mobile
      Vote for your favorite feature requests and the bugs you want to see fixed.

      Comment


      • #4
        Originally posted by Wayne Luke View Post
        This is due to the Javascript compiler we switched to in vBulletin 5.6.2. The previous compiler is not longer in production or supported. I've attached a recompiled file using the older compiler.
        Thanks for the quick fix! We'll try 5.6.2 with that file instead of original.

        Comment


        • #5
          Wayne Luke I had the same problem, and solved replacing the provided file, thank you !

          Comment


          • #6
            The vBulletin 5.6.2 download has been updated with this file. A more comprehensive fix (updating/removing some outdated code) will be applied in 5.6.3.
            Translations provided by Google.

            Wayne Luke
            The Rabid Badger - a vBulletin Cloud demonstration site.
            vBulletin 5 API - Full / Mobile
            Vote for your favorite feature requests and the bugs you want to see fixed.

            Comment


            • #7
              I just replaced this but the buttons still don't work? If you copy the original of the modified it still show red?? Is there another way to reset to original?

              Comment


              • Wayne Luke
                Wayne Luke commented
                Editing a comment
                Clear your browser cache and try again.

                If you copy a template, it will not replace the original. It will not show as modified. It will be a new custom template.

            • #8
              That did the trick. Thanks!

              Comment

              Related Topics

              Collapse

              Working...
              X