[Forum] PHP Warning: when i download attachment ?

[Abo Yossef]

[B]Deprecated[/B]: The behavior of unparenthesized expressions containing both '.' and '+'/'-' will change in PHP 8: '+'/'-' will take a higher precedence in [B]/home/user/public_html/includes/class_core.php[/B] on line [B]5842[/B]

[B]PHP Warning[/B]: Use of undefined constant MYSQL_NUM - assumed 'MYSQL_NUM' (this will throw an Error in a future version of PHP) in [B]..../includes/init.php[/B] on line [B]165[/B]

[B]PHP Warning[/B]: Use of undefined constant MYSQL_ASSOC - assumed 'MYSQL_ASSOC' (this will throw an Error in a future version of PHP) in [B]..../includes/init.php[/B] on line [B]165[/B]

[B]PHP Warning[/B]: Use of undefined constant MYSQL_BOTH - assumed 'MYSQL_BOTH' (this will throw an Error in a future version of PHP) in [B]..../includes/init.php[/B] on line [B]165[/B]

[B]PHP Warning[/B]: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in [B]..../includes/functions_navigation.php[/B] on line [B]588[/B]

[B]PHP Warning[/B]: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in [B]..../includes/functions_navigation.php[/B] on line [B]612[/B]

[B]PHP Warning[/B]: Use of undefined constant THIS_SCRIPT - assumed 'THIS_SCRIPT' (this will throw an Error in a future version of PHP) in [B]..../includes/functions.php[/B] on line [B]5617[/B]

[B]PHP Warning[/B]: Use of undefined constant simpleversion - assumed 'simpleversion' (this will throw an Error in a future version of PHP) in [B]..../includes/adminfunctions.php[/B] on line [B]294[/B]

[B]PHP Warning[/B]: Use of undefined constant simpleversion - assumed 'simpleversion' (this will throw an Error in a future version of PHP) in [B]..../includes/adminfunctions.php[/B] on line [B]295[/B]
​

[Wayne Luke]

The first warning is a PHP 7.4 deprecation notice. vBulletin 4.2.5 is not compatible with PHP 7.4 and not supported under this version. The maximum allowed version of PHP is 7.2.X as indicated in the notice at the top of the screen.

Undefined Constants are most likely missing quotes around array keys because they were considered optional by some when vBulletin 4.X was written. They are not optional anymore.

Continue vs. break is another PHP "improvement" over the last 5 years since development on vBulletin 4.X stopped.

You will need to either get your hosting provider to downgrade PHP to the 7.2.X series or have them upgrade to 8.X and upgrade your forums to vBulletin 5.7.3. I recommend the second course of action. vBulletin 4.X and PHP 7.2 will continue to become more and more outdated. Even PHP 7.4 is considered end of life now.