Huge white space

[nwind]

Let me get my rbs banners re-implemented and see if that goes away. Since making it small, everything looks good to my forum members, which is what counts. I'll probably do that in a week or so. If I must have an error, invisible is good!

I very much appreciate your help!

[Wayne Luke]

theImages[0] = ''

theImages[1] = ''

The above should have the paths to your image advertising in them. That would then show in the "Blank spot". There may be a better way to achieve what you're trying to do though. If you could explain it a bit more, we can help out .

[nwind]

It suspect it is leftovers from years ago when I implemented rbs, which actually, I plan to do again. It never made a huge square like that before, but this was an upgrade from version 4.0.8.

[donald1234]

I take it you added that code? What is it meant to be for?

[nwind]

Talking to myself, I know. I changed the size to 5 instead of 450 and it looks fine, might not be right though. Is this a suitable fix?

[nwind]

I found it, but am not certain how to fix it. It's in ad_global_below_navbar. How can I fix it without crashing something else?

<div id="ad_global_below_navbar"><center>
<SCRIPT LANGUAGE="JavaScript">
var theImages = new Array()

theImages[0] = ''

theImages[1] = ''
var j = 0
var p = theImages.length;
var preBuffer = new Array()

for (i = 0; i < p; i++){
preBuffer[i] = new Image()
preBuffer[i].src = theImages[i]
}
var whichImage = Math.round(Math.random()*(p-1));

function showImage(){
if(whichImage==0){
document.write('<a href ="link.html"><img src="'+theImages[whichImage]+'" width=450></a>');
}
else if(whichImage==1){
document.write('<a href ="link.html"><img src="'+theImages[whichImage]+'" width=450></a>');
}

}

</script>

<script>
showImage();
</script>

</center><vb:if condition="$adsshown[] = 4"></vb:if></div>

[donald1234]

In firefox it shows as an image if you right click it and if you view the source code this seems to be the offending code. from line 317 to line 342

 
 var theImages = new Array()  theImages[0] = ''  theImages[1] = '' var j = 0 var p = theImages.length; var preBuffer = new Array()  for (i = 0; i < p; i++){ preBuffer[i] = new Image() preBuffer[i].src = theImages[i] } var whichImage = Math.round(Math.random()*(p-1));  function showImage(){ if(whichImage==0){ document.write('<a href ="link.html"><img src="'+theImages[whichImage]+'" width=450></a>'); } else if(whichImage==1){ document.write('<a href ="link.html"><img src="'+theImages[whichImage]+'" width=450></a>'); }  }  </script>

[nwind]

I had implemented define('SKIP_ALL_ERRORS', true); but in the wrong place. Many thanks! Now, if we can track down where this unknown image is coming from, we will be good to go.

[nwind]

It's present in both Internet Explorer and Firefox though Firefox is showing what looks like a broken image, though I cannot identify the image or see what is calling it.

[Wayne Luke]

I am not seeing a large white space or gap on your site using Google Chrome. What Browser does this occur in?

[Wayne Luke]

To make the error reporting revert to the bugged support of earlier versions add the following line to your config.php under the <?php line:

define('SKIP_ALL_ERRORS', true);

Ideally, you would have display_errors turned off in a production environment. Your hosting provider would have to do that. Having them on is a minor security risk.

[nwind]

Turning it on now. I could also use any ideas on suppressing or fixing the errors.

[Wayne Luke]

White space like that is most commonly caused by improperly closed HTML tags. Would need to see the site on and functioning to look at the generated HTML.

[nwind]

http://www.jouster.com/forums, thank you!

[donald1234]

A link to your site would help