Adsense Integration - init.php

[veenuisthebest]

Hello,

As stated in the stickied thread here, 3 files are added and 1 file is changed which in init.php

Q. I downloaded 3.8.0 and upgraded before I integrated my Adsense account. How do I get ads to show?
A. After integration, redownload vBulletin 3.8.0 and then upload the following files:
admincp/deployads.php, includes/init.php, includes/adsense_templates.php, and includes/xml/cpnav_ads.xml.

Because I am not interested in this feature at all, I have removed all access from adsense as well as got my Members Area free from association via Support ticket.

NOW, as quoted above that INIT.PHP is changed in the two versions (vbulletin with adsense code/files and vbulletin without adsense code/files)

On comparing BOTH init.php's, I find this which really makes NO SENSE and making me sick:-

init.php with Adsense Integration:-

// Add AdSense if present
$vbulletin->adsense_pub_id = 'ca-pub-xxxxxxxxxxxx my pub-ID';
$vbulletin->adsense_host_id = 'pub-2606800903002383'; 

init.php without Adsense Integration:-

// Add AdSense if present
$vbulletin->adsense_pub_id = '';
$vbulletin->adsense_host_id = 'pub-2606800903002383'; 

SOO.... I am happy that you DID remove my pub-id BUT why in the world your host ID is still there????

If I am not wrong init.php is executed globally, what is vBulletin's host ID STILL doing in there.

Thank you

[Colin F]

It's not doing anything at all. It's not used anywhere if the pub id is not set.

[veenuisthebest]

Thanks for the reply.

I understand it isn't doing anything. BUT when our pub-id has been removed, it would seriously make more sense to remove the host-id as well. Infact, that 3 line code should be removed in the non-adsense version.

Its a bug I would say, and I would feel more confident if this is done in the package

I have manually removed it though.

[Fusion]

Just a small note, the host_id is included in all downloads of 3.8, even for those that never had any pub-id associated.
One might question why unused code is left active and not commented out.

[rex_b]

Very interesting. Yet another reason why this could be added via the AdminCP..

[cpvr]

What 3 files are they?

[veenuisthebest]

You did not read the quote in the first post.

3 files added:- admincp/deployads.php, includes/adsense_templates.php, and includes/xml/cpnav_ads.xml.

1 file changed:- includes/init.php

[xxalexkimxx]

It's not doing anything at all. It's not used anywhere if the pub id is not set.

It will be use if the pub id is set right? So what does that mean? you mean vbullet pub-id will be use too?

[eJM]

Why didn't they just keep the non-integrated package without the Adsense lines? If you have to upload a new init.php file with the Adsense package, why bother putting ANY Adsense code, since it isn't being used, in the non-Adsense package?

Jim

[veenuisthebest]

Why didn't they just keep the non-integrated package without the Adsense lines? If you have to upload a new init.php file with the Adsense package, why bother putting ANY Adsense code, since it isn't being used, in the non-Adsense package?

Jim

The reason for this has been mentioned earlier somewhere.

Their system is designed to add/remove only a few characters or a single line of code during that zip build-up process.