forumhome issue - any help would be appreciated

**Wassouf** · Wed 12 Sep '07, 1:26pm

someone please help?

**Steve Machol** · Wed 12 Sep '07, 3:20pm

I don't see anything wrong. You might want to clarify what you mean.

**Jose Amaral Rego** · Wed 12 Sep '07, 7:05pm

I think it is those images that seem not to be repeating properly on the left and right side. They are bunch up on near top left..

**kira** · Wed 12 Sep '07, 7:17pm

Originally posted by Wassouf

someone please help?

Hi Wassouf. There are some very weird things going on in your templates -- either your header or headinclude, I'm not sure which.

There's either a table code in your HEADINCLUDE template (which should definitely not be there, since tables should never be inside the HEAD tag), or you have extra HEAD tag/javascript fuctions/meta/body tag stuff going on in your HEADER template.

This is the outputted code, starting with the first (of two!) body tags and ending with the second body tag:

Code:

<body>
<table width="100%" border="0" cellspacing="0" cellpadding="0">
  <tr> 
 
 
 
<TD WIDTH="0.5%" HEIGHT="100%" valign=top background="images/FWS/misc/left_repeat.gif"><IMG SRC="images/FWS/misc/border_left.gif" WIDTH="1" HEIGHT="1"></TD>
<TD WIDTH="25" HEIGHT="100%" valign=top background="images/FWS/misc/border_left.gif"><IMG SRC="images/FWS/misc/border_left.gif" WIDTH="25" HEIGHT="1"></TD>
 
 
 <td>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=windows-1256">
<script type="text/JavaScript">
<!--
function MM_findObj(n, d) { //v4.01
  var p,i,x;  if(!d) d=document; if((p=n.indexOf("?"))>0&&parent.frames.length) {
    d=parent.frames[n.substring(p+1)].document; n=n.substring(0,p);}
  if(!(x=d[n])&&d.all) x=d.all[n]; for (i=0;!x&&i<d.forms.length;i++) x=d.forms[i][n];
  for(i=0;!x&&d.layers&&i<d.layers.length;i++) x=MM_findObj(n,d.layers[i].document);
  if(!x && d.getElementById) x=d.getElementById(n); return x;
}
function MM_preloadImages() { //v3.0
  var d=document; if(d.images){ if(!d.MM_p) d.MM_p=new Array();
    var i,j=d.MM_p.length,a=MM_preloadImages.arguments; for(i=0; i<a.length; i++)
    if (a[i].indexOf("#")!=0){ d.MM_p[j]=new Image; d.MM_p[j++].src=a[i];}}
}
function MM_swapImgRestore() { //v3.0
  var i,x,a=document.MM_sr; for(i=0;a&&i<a.length&&(x=a[i])&&x.oSrc;i++) x.src=x.oSrc;
}
function MM_swapImage() { //v3.0
  var i,j=0,x,a=MM_swapImage.arguments; document.MM_sr=new Array; for(i=0;i<(a.length-2);i+=3)
   if ((x=MM_findObj(a[i]))!=null){document.MM_sr[j++]=x; if(!x.oSrc) x.oSrc=x.src; x.src=a[i+2];}
}
//-->
</script>
</HEAD>
<BODY BGCOLOR=#FFFFFF LEFTMARGIN=0 TOPMARGIN=0 MARGINWIDTH=0 MARGINHEIGHT=0 onLoad="MM_preloadImages('images/forum.a.gif','images/home.a.gif','images/FWS/head/forum.a.gif','images/reviews.a.gif','images/search.a.gif','images/news.a.gif')">

You can check either of the two templates to see where the extraneous stuff is coming from. Or if you want you can attach or PM me your HEADER and HEADINCLUDE templates (text files) and I can help identify which has the weird stuff.

(Oh -- I should add, the footer might also be messed up. There's a </tr> tag right after a closing table tag, whereas it should come after a </td> tag instead. It all has to do with the nesting table and background/side graphics. So if you want, send that along as well.)

**kira** · Wed 12 Sep '07, 8:31pm

In doing some experimenting with your code, I have to say it's kinda messed up, not just in the templates I mentioned but in FORUMHOME as well. (Several missing/incorrectly formed tables, and there's even a FORM tag that's not closed.) I see that it's a custom style, which means you probably paid for this. I'd give it back to the designer to fix or hire someone else to do so.

(In fairness to the designer, it's very possible that the style was correct when they provided it to you -- maybe someone else toyed with it afterwards. As a designer myself I know this does indeed happen.

)

It's not extremely difficult to fix, though. I took the liberty of straightening out the HTML on a static test page so you can see what it's supposed to look like.

**Wassouf** · Wed 12 Sep '07, 11:16pm

Originally posted by kiwilerner

In doing some experimenting with your code, I have to say it's kinda messed up, not just in the templates I mentioned but in FORUMHOME as well. (Several missing/incorrectly formed tables, and there's even a FORM tag that's not closed.) I see that it's a custom style, which means you probably paid for this. I'd give it back to the designer to fix or hire someone else to do so.

(In fairness to the designer, it's very possible that the style was correct when they provided it to you -- maybe someone else toyed with it afterwards. As a designer myself I know this does indeed happen.

)

It's not extremely difficult to fix, though. I took the liberty of straightening out the HTML on a static test page so you can see what it's supposed to look like. My guess is your page should look like this sample, right?

Hello, thanks for taking the time to help on this matter.
I have created this skin myself, it is working just perfect on my own graphics site and my local server but for some reason no luck on my client forum.

I sent you a PM with the header and headerinclude code.

Thanks.

**kira** · Thu 13 Sep '07, 12:00am

I see! Well, then you're to blame.

No seriously, it's a few issues that are causing some different problems. Now that I see the header/headinclude templates I can narrow them down and have fixed some of them, but some stray issues will still occur due to the footer, forumhome and possibly the navbar templates as well.

- There were onLoad/javascript functions, a meta tag, and a duplicate body tag all in the header template. Since all of these (except the body tag) belong in the HEAD section, they should be in headinclude.

- The body tag needed to be removed altogether, as (unfortunately) vBulletin requires you to edit the BODY tags individually within forumhome, forumdisplay, and basically every main page template.

- The headinclude contained an IMG code that doesn't belong there. This:

Code:

[IMG]file:///C:/DOCUME%7E1/User/LOCALS%7E1/Temp/moz-screenshot.jpg[/IMG][IMG]file:///C:/DOCUME%7E1/User/LOCALS%7E1/Temp/moz-screenshot-1.jpg[/IMG]

As I mentioned via PM, the missing or incomplete tables, as well as the incomplete FORM tag, are probably being caused by the forumhome, navbar and/or footer templates. I'll need those if you'd like me to help those areas too!

forumhome issue - any help would be appreciated

forumhome issue - any help would be appreciated

Comment

Comment

Comment

Comment

Comment

Comment

Comment